fix
This commit is contained in:
@@ -62,7 +62,6 @@ func TestScoreV1ProcessCompletedItem_flagsGaps(t *testing.T) {
|
||||
}
|
||||
joined := strings.Join(sc.FailFlags, ",")
|
||||
for _, want := range []string{
|
||||
"missing_name",
|
||||
"description_empty_with_title",
|
||||
"meta_title_missing",
|
||||
"meta_description_missing",
|
||||
@@ -103,7 +102,7 @@ func TestEnforceV1ProcessCompletedItem_fillsDescriptionMetaSanitizes(t *testing.
|
||||
if desc == "" {
|
||||
t.Fatal("expected nonempty description")
|
||||
}
|
||||
if descriptionEchoesTitle(desc, fmt.Sprint(out["title"])) {
|
||||
if descriptionEchoesTitle(desc, fmt.Sprint(out["name"])) {
|
||||
t.Fatalf("EnforceV1 must replace weak/echo desc, got title-echo: %q", desc)
|
||||
}
|
||||
if containsWeakFillerPhrase(desc) {
|
||||
@@ -131,8 +130,16 @@ func TestEnforceV1ProcessCompletedItem_fillsDescriptionMetaSanitizes(t *testing.
|
||||
if _, bad := attrs["name"]; bad {
|
||||
t.Fatalf("reserved name kept: %v", attrs)
|
||||
}
|
||||
if out["name"] != out["title"] {
|
||||
t.Fatalf("name should mirror title: name=%v title=%v", out["name"], out["title"])
|
||||
if out["name"] == nil || strings.TrimSpace(fmt.Sprint(out["name"])) == "" {
|
||||
t.Fatalf("name missing: %v", out["name"])
|
||||
}
|
||||
if _, ok := out["title"]; ok {
|
||||
t.Fatalf("duplicate title should be omitted when name exists: %v", out["title"])
|
||||
}
|
||||
for _, junk := range []string{"id", "processed_product_id", "raw_product_id"} {
|
||||
if _, ok := out[junk]; ok {
|
||||
t.Fatalf("%s must be omitted: %v", junk, out)
|
||||
}
|
||||
}
|
||||
sc := ScoreV1ProcessCompletedItem(out, ScoreV1ProcessItemOptions{MappedCategory: "28"})
|
||||
if !sc.OK {
|
||||
|
||||
Reference in New Issue
Block a user